Introduce placeholder express methods

[maxparkergene]

Previously there was a large CSL score because all of the Adyen Express methods were being lazy loaded and only showing after the network request had finished.

The BlueFinch Checkout has had an update allowing for placeholder express methods to be rendered and remain visible until the lazy loading of the full Express methods.

This update introduces these placeholders and then switches them out after we have fully rendered the express methods.

[convenient]

@maxparkergene This will currently fire after all section data loads, but if adyen express payments is enabled we're already doing this request once. This will help reduce load on adyen and keep this lean

We need to handle two cases

• Adyen express enabled
  • we need to check storeConfigPaths to see if express is active and enabled
  • if it is, then we terminate this plugin because we dont want to duplicate api requests
  • we also need a new plugin or extension, after the adyen express functionality to grab that payload and use it for our purposes. so that we dont run the same request twice
• Adyen express not enabled
  • use this implementation, as its very similar to the adyen express method.

[maxparkergene]

Hi @convenient,

Thanks for the feedback and I have added the checks as you've suggested to only run the Adyen API request if the express module is not enabled. If it is there is a separate plugin that will take the data and use it as we are expecting in BlueFinch checkout.

[tr33m4n]

@maxparkergene Looking good, added a comment about idle packages

[tr33m4n]

@maxparkergene As the package can be installed and potentially not configured, we could see duplicate requests just with the express module sitting in the background. The better check here might be something using the \Magento\Framework\Module\Manager like:

if (!$this->moduleManager->isEnabled('Adyen_ExpressCheckout')) {
    //
}