fix(timeout): wire 600s default into OpenAI + Anthropic compat wrappers (follow-up to #6)#7
Merged
Merged
Conversation
Follow-up to #6, which added the env-configurable 600s DEFAULT_TIMEOUT but only wired it into the native LLMClient path. The OpenAI/Anthropic drop-in wrappers hardcoded 60000ms (openai-compat passed truthy 60000 into LLMClient; anthropic-compat used it directly), so README drop-in users still timed out at 60s on reasoning calls. Export DEFAULT_TIMEOUT from client.ts; both wrappers now fall through to it. Fix stale default:60000 doc comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#6 added the env-configurable 600s
DEFAULT_TIMEOUTbut only wired it into the nativeLLMClient. The two README drop-in wrappers still hardcoded60000ms:openai-compat.tspassed truthy60000into LLMClient (shadowing the default)anthropic-compat.tsused?? 60000directlySo OpenAI()/AnthropicClient() users still timed out at 60s on reasoning calls (opus-4.8/deepseek-v4-pro). This exports
DEFAULT_TIMEOUTand routes both wrappers through it, and fixes staledefault: 60000docs. Typecheck + build green.