revert(x402): drop client-side builder-code service code stamping#4
Open
VickyXAI wants to merge 1 commit into
Open
revert(x402): drop client-side builder-code service code stamping#4VickyXAI wants to merge 1 commit into
VickyXAI wants to merge 1 commit into
Conversation
Reverts the client-side `s: ["blockrun"]` service-code tagging added in #2. BlockRun is the seller/app, not a payment intermediary, so attribution belongs in the seller-side app code (`a`) set by the server on its 402 — not stamped onto every payment this client SDK signs. Removing it also avoids handing CDP a branded, aggregated view of BlockRun's payment volume from the buyer side. - Drop withBuilderCodeServiceCode() and BlockRunServiceCode from x402.go - CreatePaymentPayload passes server extensions through unchanged (any echoed app code `a` is still preserved) - Remove x402_test.go (covered only the removed service-code behavior)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts the client-side builder-code service code (
s: ["blockrun"]) stamping added in #2. This SDK no longer tags payments with a builder code.Why
We decided attribution should live server-side as the app code (
a), not client-side as the service code (s):a, set by the server on its 402 — notsstamped by the buyer SDK.aattributes every payment to BlockRun regardless of which client the buyer uses; client-sidesonly caught payments made through this specific Go SDK.ais set once in the server (tracked in BlockRunAI/blockrun#199) instead of duplicated across every SDK (Go/Python/TS).Changes
withBuilderCodeServiceCode()andBlockRunServiceCodefromx402.go.CreatePaymentPayloadpasses the server-providedextensionsthrough unchanged — any echoed app codeais still preserved.x402_test.go(it only covered the removed service-code behavior).Test
go build ./...,go vet ./...,go test ./...all green.Follow-up
Seller-side app code
a(using registered builder codebc_5hucoh0l) to be implemented in theblockrunserver repo — BlockRunAI/blockrun#199.