Exclude free games from search results - #7
Merged
Conversation
_outright_price only matched CTAs where upSellService == "NONE" (the string). Some regions return the field as null instead, causing the CTA to be skipped and price to show as N/A even though the game is purchasable. Accept null as equivalent to "NONE". Also replace `/ divisor or None` with an explicit None-guard so that a legitimately zero-valued discountedValue is preserved rather than silently collapsed to None. https://claude.ai/code/session_01GKfcq8EE1cMxAfJrKZLx72
Games where no region has a purchasable price (price=None in all regions after search + fallback) are now filtered out from the list. Previously they appeared with N/A prices (e.g. Minecraft Demo). https://claude.ai/code/session_01GKfcq8EE1cMxAfJrKZLx72
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Игры, у которых нет цены ни в одном регионе пользователя (бесплатные, демо, удалённые из магазина), больше не попадают в список результатов поиска. Ранее они отображались с ценой N/A.
Test plan
get_game_info), но без цены — тоже не показываетсяpytest tests/unit/https://claude.ai/code/session_01GKfcq8EE1cMxAfJrKZLx72