fix(release): derive the LuaRocks spelling in the release verifier - #459
Merged
Conversation
The wrapper verification reported the LuaRocks rock as missing: WARN[pending]: LuaRocks gmeow-gts: package version: 1.0.0-rc.1-1 not present It was published, as 1.0.0rc1-1. A rockspec version is parsed as `[%w.]+-[%d]+`, so the part before the revision admits only alphanumerics and dots and a semver pre-release cannot be spelled there -- the same constraint that made scripts/check-versions.sh derive the LuaRocks spelling when the candidate was cut. The verifier still assumed `<version>-1`, so it looked for a version that by construction can never exist and reported a correctly published artifact as absent. Derives the spelling instead, so the two agree by construction rather than by someone remembering to pass --luarocks-version. A final release has no pre-release part and is unchanged. Also adds the missing `import re`: the module had no regex import, so the new helper would have raised NameError the first time it ran. The self-test does not reach this path, which is exactly why that needed checking by hand rather than trusting a green self-test. Verified: LuaRocks now reports PASS[published] for 1.0.0rc1-1 with its rockspec download and artifact types.
|
Warning Review limit reachedNext included review available in 34 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 99 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The wrapper verification reported the LuaRocks rock as missing:
It was published — as
1.0.0rc1-1. A rockspec version is parsed as[%w.]+-[%d]+, so the part before the revision admits only alphanumerics and dots; a semver pre-release cannot be spelled there. That's the same constraint that madescripts/check-versions.shderive the LuaRocks spelling when the candidate was cut. The verifier still assumed<version>-1, so it looked for a version that by construction can never exist and reported a correctly published artifact as absent.Now it derives the spelling, so the guard and the verifier agree by construction rather than by someone remembering to pass
--luarocks-version. A final release has no pre-release part and is unchanged.Also adds a missing
import re— the module had no regex import, so the new helper would have raisedNameErrorthe first time it ran. The--self-testdoes not reach this path and passed regardless, which is precisely why it needed checking by hand.Verified