fix(release): install dkjson into the system luarocks tree - #456
Merged
Conversation
luarocks install dkjson failed: Error: /usr/local/lib/luarocks/rocks-5.1 does not exist and your user does not have write permissions in /usr/local/lib It has to go into the SYSTEM tree, because the consumer is the `luarocks` binary itself loading a JSON library for its own upload command. A --local install lands in ~/.luarocks, which luarocks does not consult when resolving its own command implementations.
|
Warning Review limit reachedNext included review available in 45 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 98 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #455.
luarocks install dkjsonfailed:It has to go into the system tree, because the consumer is the
luarocksbinary itself loading a JSON library for its ownuploadcommand. A--localinstall lands in~/.luarocks, which luarocks does not consult when resolving its own command implementations.