fix(release): pass all three fixtures to the LuaRocks smoke test - #454
Merged
Conversation
The LuaRocks lane got as far as packing the rock and then died: luajit: lua/tests/smoke.lua:66: missing damaged fixture path smoke.lua takes THREE fixtures -- clean, damaged and empty -- and has done since its structured-error assertions were added. The release workflow still passed only vectors/01-minimal.gts. Third release-lane bug this cut has surfaced with the same shape: the wrapper package dry run does the right thing (scripts/package_dry_run_wrappers.sh:501 passes all three) while the lane it rehearses does not, and only the dry run was ever exercised. There were no lua-v tags before this release, so nothing had ever run this path. lint, make and pack all succeeded, so the rock builds correctly; only the post-pack smoke invocation was wrong.
|
Warning Review limit reachedNext included review available in 8 minutes. View limit detailsLimit details: You’ve used the included review currently available. Your 97 included PR review attempts over the past 7 days set your current allowance at 1 review per hour. Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LuaRocks lane packed the rock successfully and then died:
smoke.luatakes three fixtures — clean, damaged, empty — and has since its structured-error assertions were added. The release workflow still passed onlyvectors/01-minimal.gts.This is the third release-lane bug this cut has surfaced with the same shape:
scripts/package_dry_run_wrappers.shdoes the right thing (:501passes all three) while the lane it is supposed to be rehearsing does not — and only the dry run was ever exercised. There were nolua-vtags before this release, so nothing had run this path.lint,makeandpackall succeeded, so the rock itself is fine; only the post-pack smoke invocation was wrong.