Repository navigation
Weight transfer and queue progress by selected bytes - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tiny sidecar could advance a transfer as much as a huge clip, overlapping verification could move the bar backward, and MHL/report work could reset it. Transfer and destination progress now use capped per-file byte-work budgets. The queue weights known card sizes, destination counts and verification modes; unknown sizes stay indeterminate.
The same budget continues through MHL and Finishing. Partial failures retain the original denominator, final callbacks cannot lose the budget, and active work stays below 100%. Reused files settle a logical work estimate after their checks; this percentage is separate from actual I/O counters and transfer evidence.
Validation: the mixed-size regression genuinely fails on main at 25% and passes here. Focused coverage includes fresh/reused transfers, cancellation, failed writes, partial/no-job MHL, unknown-size queues and 10,000 files. Full local engine suites, Mac app suite and universal mobile build passed. Independent review found and verified fixes for wrapper/callback/partial-budget issues. Physical and signed-app walkthroughs remain open; verification policy and digests are unchanged.