Repository navigation
Clarify verification claims and test source-read faults - #31
Merged
Merged
Conversation
…aims-20261017 # Conflicts: # Packages/BitMatchEngine/Sources/BitMatchEngine/Models/Verification.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
The README and guide now describe what each verification mode actually checks. Quick checks sizes; Standard reads each backup back with SHA-256. For a new copy, it compares that readback with the source hash made during copying. When an existing file is reused, it checks against a fresh source read. Thorough and Paranoid reread the card. The README also makes clear that two folders on one physical drive are one backup, not two independent backups.
The new fault tests pin the important limit: Standard can miss a transient wrong read from the card during copying, while Thorough and Paranoid catch that scenario. If every read of the card returns the same wrong bytes, no mode can establish the original camera bytes without outside evidence. This is a test of the assurance boundary, not evidence that BitMatch has corrupted a user's footage.
Local validation
ComparisonDiagnosticTestsand was stopped; its result is inconclusive. The standalone Mac app test suite has not completed on this host; no Mac app test pass is claimed.GitHub Actions started automatically when this draft was first pushed. Earlier observed Mac jobs stopped before tests during an Xcode 26.3 compiler IR-generation crash in
PreferencesWindow.swift; engine jobs stopped before tests on Swift concurrency compile errors inChecksumTruncationTests.swiftandStressTests.swift. The same compile failures appeared on the existing #28 CI branch. Evidence-corpus jobs passed in that earlier run. These are prior observations, not a new hosted CI result for the wording follow-up. No manual CI rerun was requested. This remains a draft until the standalone Mac app test execution can be checked.