Repository navigation
Keep Mac unit tests away from mounted drives - #29
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mac app unit tests launch a BitMatch app host before their fixtures run. That host was starting live volume discovery and loading saved app state, which could touch mounted media and contribute to access prompts or stalled test startup.
In DEBUG XCTest hosts, startup now uses isolated in-memory state, no SFTP scheduler, and no live
/Volumesscan or Disk Arbitration registration. The Release path and entitlements are unchanged. Tests assert the host detection and that the singleton never starts drive monitoring in the unit-test process.Local validation: focused Mac host tests 4/4 passed; drive-access policy tests 3/3 passed. After this was combined with the other draft slices, the full Mac suite passed (267 XCTest cases, 12 intentional skips, plus 888 Swift Testing cases) and Mac/iOS Release builds passed. An earlier zero-case filter run was discarded. This does not prove every UI or signed-app test is prompt-free.
GitHub Actions started automatically when this draft was pushed. Observed Mac jobs stop before tests during an Xcode 26.3 compiler IR-generation crash in
PreferencesWindow.swift; engine jobs stop before tests on Swift concurrency compile errors inChecksumTruncationTests.swiftandStressTests.swift. The same compile failures appear on the existing #28 CI branch. Evidence-corpus jobs pass. No manual CI rerun was requested; the local results above are the review evidence for this draft.