Repository navigation
Make off-site backup evidence explicit - #26
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Off-site results could make an upload-only file look too much like one that BitMatch downloaded and checked. The UI now says Uploaded · Unverified for upload-only work and Uploaded · Downloaded and checked only when saved SHA-256 readback evidence supports it. Older server-checksum evidence keeps its own label.
The saved card summary now checks every manifest entry, terminal byte count, and digest before showing a fully backed-up result. Missing or inconsistent evidence stays non-green, including after relaunch. The setup copy explains the two modes.
Local validation: full engine suite passed (129 XCTest cases, 17 opt-in skips; 160 Swift Testing cases), full Mac app suite passed, iPad build passed, and iPad and iPhone simulator suites passed.
git diff --checkpassed. The queue/provider tests use local fakes; I did not test against a live SFTP server. Existing report files are snapshots made before a later off-site queue finishes, so they do not update retroactively.GitHub's Mac and engine jobs remain red with the same Xcode 26.3 / Swift 6.2.4 compiler failures already present on main; the iPad build and evidence jobs pass. The local Mac and engine suites above ran successfully with this change.