Repository navigation
Keep transfer outcomes and Mac card discovery aligned with evidence - #25
Merged
Merged
Conversation
Keep active progress and finished verdicts aligned with durable transfer evidence, including Quick report failures. Reconcile replaced Mac card mounts before selection or auto-queue. Align verification wording and add focused readback and benchmark coverage.
Preserve AppleDouble-aware selected-file counts alongside duplicate-result and terminal-state checks. Refresh roadmap status after the merged wording and SFTP evidence work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Active file work could reach 100% before ASC MHL, report writing, and the saved verdict finished. A Quick transfer with a failed report could also look like an ordinary size-only copy in History. Mac discovery could retain a stale card when a different filesystem appeared at the same mount path between notifications.
This change adds a visible Finishing state, holds active progress below 100%, checks the selected-file plan before saving or presenting a complete verdict, and records whether Quick's lack of content verification was the only issue. Finish and History now follow the saved terminal outcome. On Mac, card and drive discovery reconcile mounted filesystem identity, reject stale background analysis, clear a replaced selected source, and recheck identity before auto-queue.
It also aligns setup verification descriptions across Mac/iPhone/iPad, gives Compare its own check-plan wording, tests SFTP SHA-256 readback against downloaded remote bytes, isolates the thumbnail transfer matrix from shared cancellation state, and requests uncached source writes in the opt-in buffer benchmark. The TODO records what remains open.
Local validation:
git diff --check: clean.GitHub Actions started automatically when this draft was pushed. Observed Mac jobs stop before tests during an Xcode 26.3 compiler IR-generation crash in
PreferencesWindow.swift; engine jobs stop before tests on Swift concurrency compile errors inChecksumTruncationTests.swiftandStressTests.swift. The same compile failures appear on the existing #28 CI branch. Evidence-corpus jobs pass. No manual CI rerun was requested; the local results above are the review evidence for this draft.Still open before release: signed-app removable-card walkthrough, physical-drive benchmark/drive-counter confirmation, and field evidence for the active user reports. Synthetic tests do not establish that those reports are fixed.