Repository navigation
Check complete saved evidence and expand MHL compatibility tests - #21
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check could trim whitespace from recorded filenames, resolve nested ASC inventories from the wrong folder, and silently drop damaged or unsupported records beside readable ones. That could leave files out of a saved-checksum check. The reader now preserves paths, resolves each inventory from its own folder, handles namespace prefixes and refuses incomplete or unsupported file evidence. Check explains the refusal and states the file-content scope of successful ASC checks. Unknown report algorithms no longer imply Standard verification.
A permanent, redistributable corpus contains original synthetic media and inventories generated by the official ASC reference CLI: MD5/XXH64, two generations, C4-only unsupported evidence, zero-byte files, Unicode/XML escaping and whitespace filenames. Derived regressions cover corrupt records, conflicting duplicates, traversal, failed actions, namespaces, versions and entities. JSON fixtures cover current, legacy, extended, Quick, unsafe, unknown and truncated reports.
The reference harness now links the real package generator instead of its removed pre-package path. It validates both the corpus and fresh BitMatch output, including appending a generation and rejecting changed media. Engine tests explicitly use serial test-case scheduling; each case still exercises concurrent transfer workers.
Validation and qualifications: evidence compatibility record. The original corpus failed behaviorally before the fixes, and both new app-level guards were mutation-checked. An existing two-second fan-out test setup deadline failed under concurrent cases; its isolated and explicit serial runs passed. Those failures are retained in the record.
This changes saved-evidence reading, not media copying or MHL publication. Classic-MHL discovery, full ASC history/structure verification and history extension remain unsupported.