Repository navigation
Fix saved-checksum discovery crash and clarify comparison diagnostics - #15
Merged
Merged
Conversation
mikecerisano
marked this pull request as ready for review
October 5, 2026 17:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check could terminate the app when selecting a folder with a multi-file MHL or JSON report. Saved-checksum discovery treated each file's record URL as unique. Collect each contributing record once while preserving per-file evidence, newest-record selection and corruption detection. A two-file MHL/JSON regression reproduces the original fatal traps.
Also clarify missing/extra comparison results and existing hidden macOS companion conflicts, add privacy-safe comparison phases/counts/outcomes and correctly correlate cancellation, and stop offering Eject for internal folders. No overwrite, readback or safety-verdict protections are relaxed.
Validation performed locally (CI is not the acceptance gate):
The Mac test-host loader stall was resolved by using derived data outside Desktop, with no signing/privacy changes. Earlier failed/stalled attempts are documented separately.
Keep #8 open: the supplied Sony XML/BIM files remain private and local. The Check crash is confirmed; the reporter's later Copy & Verify failure is not reproduced. No original MOV footage or physical Sony reader was tested. No release/version change or publication in this PR.