Repository navigation
Fix large-file verification memory growth and prepare 0.2.4 - #13
Merged
Merged
Conversation
Reviewed and adapted the supplied untested patch, reproduced memory growth on Darwin, and added isolated memory and real-driver transfer regressions. Co-authored-by: Claude <noreply@anthropic.com>
mikecerisano
marked this pull request as ready for review
October 5, 2026 02:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large destination verification reads retained temporary buffers on macOS. Put each read and hash inside an autorelease pool, keeping memory bounded by chunks rather than file size. Add privacy-safe memory, numbered-file, destination and verification outcome diagnostics, plus an optional worker-count override for investigation. Source identity checks, uncached destination readback, no-overwrite publication and fail-closed verdicts remain intact.
Prepares 0.2.4 (build 14). Issue #10 remains open: this fixes a reproduced memory defect, but does not establish why the reporter's process stopped.
Validation:
Limit: full Mac app tests built but the test host stalled in dyld before app code; those tests are not claimed green. Local engine checks and the signed-app walkthrough provide the validation here. Sparse synthetic stress files do not reproduce the reporter's physical dock/HDD or camera media.