feat(abstract-cosmos): support execType for group proposal execution mode (CSHLD-972)#8988
Draft
prajwalu142 wants to merge 1 commit into
Draft
feat(abstract-cosmos): support execType for group proposal execution mode (CSHLD-972)#8988prajwalu142 wants to merge 1 commit into
prajwalu142 wants to merge 1 commit into
Conversation
…cution mode (CSHLD-972) Adds execType field to CosmosLikeTransaction and threads it through the builder chain so callers can control whether a group.v1 MsgSubmitProposal executes immediately (EXEC_TRY=1) or defers to chain governance queue (EXEC_UNSPECIFIED=0). The field is applied only during getSendMessagesForEncodingTx when the message typeUrl matches groupProposalMsgTypeUrl, leaving all other Cosmos chains and message types unaffected. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> TICKET: CSHLD-972
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
execType?: stringtoCosmosLikeTransactioninterface so the field flows through the full transaction build chainexecType()setter toCosmosTransactionBuilderfollowing the existingfeeGranterpatterngetSendMessagesForEncodingTx, appliesexecTypetoMsgSubmitProposalmessages only — setsdecoded.exec = 1forEXEC_TRY(immediate execution) or0forEXEC_UNSPECIFIED(defer to governance queue). Guard onexecType !== undefinedensures zero behaviour change for all other Cosmos chainssdk-coin-hashcovering setter storage and default-undefined behaviourContext
Figure Markets calls
POST /api/v2/wallet/{walletId}/txrequestsdirectly and needs to control whether Cosmosgroup.v1governance proposals execute immediately (EXEC_TRY=1) or defer (EXEC_UNSPECIFIED=0). This SDK change is part of a 3-repo stack:public-types(intent schema) →BitGoJS(this PR) →bitgo-microservices(threading from intent to builder).Test plan
yarn workspace @bitgo/sdk-coin-hash test— 3 newexecTypetests passexecTypepassed →undefinedguard preserves existing behaviour)test/api/v2/coins/hash.ts) verified in CI🤖 Generated with Claude Code