fix(ci): use Client ID (not App ID) for create-github-app-token#8985
Open
bitgo-ai-agent-dev[bot] wants to merge 2 commits into
Open
fix(ci): use Client ID (not App ID) for create-github-app-token#8985bitgo-ai-agent-dev[bot] wants to merge 2 commits into
bitgo-ai-agent-dev[bot] wants to merge 2 commits into
Conversation
bitgo-ai-agent-dev
Bot
force-pushed
the
ai-254/replace-app-id-with-client-id
branch
from
b01df7d to
ad0694a
Compare
ericcrosson-bitgo
previously approved these changes
Jun 10, 2026
venkateshv1266
previously approved these changes
Jun 10, 2026
bitgo-ai-agent-dev
Bot
force-pushed
the
ai-254/replace-app-id-with-client-id
branch
2 times, most recently
from
3b46254 to
de5c59e
Compare
ericcrosson-bitgo
force-pushed
the
ai-254/replace-app-id-with-client-id
branch
3 times, most recently
from
9e545ff to
6b1682a
Compare
ericcrosson-bitgo
dismissed stale reviews from venkateshv1266 and themself
via
93f34d6
ericcrosson-bitgo
force-pushed
the
ai-254/replace-app-id-with-client-id
branch
from
6b1682a to
93f34d6
Compare
The create-github-app-token action deprecated app-id in favour of client-id. These inputs accept different values: app-id takes the numeric App ID (1819979), client-id takes the alphanumeric OAuth Client ID (Iv23lipbCWzUuCxFerKJ). Rename STATIC_ANALYSIS_BOT_APP_ID to STATIC_ANALYSIS_BOT_CLIENT_ID, set value to Iv23lipbCWzUuCxFerKJ, rename app-id to client-id, and upgrade action from v2 to v3. Ref: BitGo/advanced-wallets#233 Ticket: AI-273 Session-Id: 4ea37ed2-bb6a-43da-848a-66a70262d221 Task-Id: 4523dbe1-5473-46a2-824f-14a84177962f
bitgo-ai-agent-dev
Bot
force-pushed
the
ai-254/replace-app-id-with-client-id
branch
from
b60f5cf to
e2ce14e
Compare
bitgo-ai-agent-dev
Bot
changed the title
ericcrosson-bitgo
approved these changes
Jun 11, 2026
Contributor
|
Looks like the commit message needs updating, however! |
alextse-bg
reviewed
Jun 11, 2026
alextse-bg
left a comment
alextse-bg
left a comment
Contributor
There was a problem hiding this comment.
lint issue, otherwise lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
STATIC_ANALYSIS_BOT_APP_ID→STATIC_ANALYSIS_BOT_CLIENT_ID1819979) to alphanumeric OAuth Client ID (Iv23lipbCWzUuCxFerKJ)app-id:input toclient-id:in theactions/create-github-app-tokenstepactions/create-github-app-tokenfromv2tov3Why
The
actions/create-github-app-tokenaction deprecatedapp-idin favour ofclient-id. Critically, these two inputs correspond to different values:app-id: accepts the numeric App ID (e.g.1819979)client-id: should receive the alphanumeric OAuth Client ID (e.g.Iv23lipbCWzUuCxFerKJ)A prior PR only renamed the input key but kept the numeric App ID value, which is semantically wrong. This PR completes the fix with the correct Client ID value.
Ref: BitGo/advanced-wallets#233 (canonical correct fix)
Ticket: AI-273
🤖 Generated with Ralph