Warn before truncated value displays#2007
Open
benma-agent wants to merge 1 commit into
Open
Conversation
2f9d028 to
b395cb2
Compare
Show the existing large-value warning before value confirmation bodies that exceed the UI label limit. Apply it to shared message verification, Ethereum transaction and typed-data values, and BTC policy name/policy displays.
b395cb2 to
69a1dd7
Compare
cedwies
approved these changes
Jul 11, 2026
cedwies
left a comment
Collaborator
There was a problem hiding this comment.
utACK.
Nit: bitbox02-firmware/src/ui/components/label.h still has the stale comment // Keep this in sync with src/rust/bitbox02-rust/src/hww/api/ethereum.rs:MAX_CONFIRM_BODY_SIZE
Nit: BTC policy display now uses confirm_value() but there is no direct policy-specific long-policy test. But I leave that up to you if you want to add another test for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification