Fixed bugs in aws outbound-assumed-roles#135
Open
toktarbayevaaiymgul wants to merge 1 commit into
Open
Conversation
toktarbayevaaiymgul
requested review from
bishopfaure and
jbarciabf
as code owners
sethsec
approved these changes
Jun 25, 2026
Collaborator
|
@jbarciabf / @bishopfaure - I have confirmed that this works as expected now. Please merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Card
Fixed bugs in aws outbound-assumed-roles
Details
This PR involves 4 related bug fixes, identified when cloudtrail:LookupEvents were failing with AWS error "InvalidTimeRangeException: The start time precedes the end time" after running "cloudfox aws outbound-assumed-roles"
Fixed incorrect startTime calculation in /aws/outbound-assumed-roles.go (both locations) to calculate absolutel value of m.Days to properly handle potential negative numbers
Changed -7 to 7 when building OutboundAssumedRolesCommand in /cli/aws.go
Uncommented LookupAttributes for "BatchGetImage" in cloudtrail:LookupEvents call in getCrossAccountBatchGetImageEntriesPerRegion method (assuming it was previously commented when debugging startTime/endTime issue now fixed in Welcome to cloudfox Discussions! #1)
Uncommented getAssumeRoleLogEntriesPerRegion method call in executeChecks method (assuming it was previously commented when debugging startTime/endTime issue now fixed in Welcome to cloudfox Discussions! #1)
Confirmed both AssumedRole and BatchGetImage methods are now running without issue when executing "cloudfox aws outbound-assumed-roles"