Skip to content

Set up lintr and fix lints - #2

Merged
Bisaloo merged 3 commits into
mainfrom
lint
May 4, 2026
Merged

Set up lintr and fix lints#2
Bisaloo merged 3 commits into
mainfrom
lint

Conversation

@Bisaloo

@Bisaloo Bisaloo commented May 4, 2026

Copy link
Copy Markdown
Owner

No description provided.

@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

This is how benchmark results would change (along with a 95% confidence interval in relative change) if c1e64f8 is merged into main:

  • ❗🐌pkg_load: 4.49ms -> 4.94ms [+8.79%, +11.39%]
  • ✔️read_bigendian: 1.25ms -> 1.25ms [-1.01%, +1.12%]
  • ✔️read_bool: 1.21ms -> 1.21ms [-1.35%, +0.4%]
  • ✔️read_empty: 1.22ms -> 1.22ms [-1.81%, +2.25%]
  • ✔️read_float32: 1.19ms -> 1.19ms [-0.85%, +0.94%]
  • ✔️read_float64: 1.2ms -> 1.2ms [-0.76%, +0.84%]
  • ✔️read_int16: 1.23ms -> 1.22ms [-1.28%, +0.93%]
  • ✔️read_int32: 1.21ms -> 1.21ms [-0.98%, +0.42%]
  • ✔️read_int8: 1.21ms -> 1.21ms [-1.12%, +0.56%]
  • ✔️read_npz: 3.04ms -> 3.03ms [-1.53%, +0.54%]
  • ✔️read_string: 1.22ms -> 1.23ms [-0.88%, +1.62%]
  • ✔️read_uint16: 1.22ms -> 1.21ms [-1.44%, +0.75%]
  • ✔️read_uint32: 1.52ms -> 1.52ms [-1.02%, +0.39%]
  • ✔️read_uint64: 1.69ms -> 1.69ms [-0.55%, +1.45%]
  • ✔️read_uint8: 1.22ms -> 1.21ms [-1.37%, +0.66%]
  • 🚀read_unicode: 1.34ms -> 1.33ms [-2%, -0.03%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@Bisaloo
Bisaloo merged commit a827ae9 into main May 4, 2026
9 of 10 checks passed
@Bisaloo
Bisaloo deleted the lint branch May 4, 2026 12:41
@codecov-commenter

Copy link
Copy Markdown

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants