Skip to content

fix(errors): forgotten error message #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BirdeeHub merged 1 commit into from
May 14, 2026
Merged

fix(errors): forgotten error message #16

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions osenv.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,9 +158,8 @@ static int env_assign(lua_State *L, const char *key, int respect) {

static int env__newindex(lua_State *L) {
lua_settop(L, 3);
// CASE 1: bulk unset via env[{}] = {...} or env[{}] = "VAR"
// CASE 2: set if unset via env[{"KEY"}] = "VAR"
if (lua_istable(L, 2)) {
// CASE 1: set if unset via env[{"KEY"}] = "VAR"
lua_pushinteger(L, 1);
lua_gettable(L, 2);
int type = lua_type(L, -1);
Expand All @@ -174,9 +173,10 @@ static int env__newindex(lua_State *L) {
lua_pop(L, 1);
return env_assign(L, key, 1);
} else {
return luaL_error(L, "", lua_typename(L, lua_type(L, -1)));
return luaL_error(L, "Key for setting if unset must be convertable to a string, but received %s", lua_typename(L, lua_type(L, -1)));
}
} else {
// CASE 2: bulk unset via env[{}] = {...} or env[{}] = "VAR"
lua_pop(L, 1);
}
if (lua_type(L, 3) == LUA_TSTRING) {
Expand Down