some more features - #7
Merged
Merged
Conversation
t0mdavid-m
reviewed
Jul 1, 2026
| import streamlit as st | ||
| st.divider() | ||
| try: | ||
| st.page_link("content/ptxqc_run.py", label="Next: **3. Create Report**", icon="🚀") |
Collaborator
There was a problem hiding this comment.
In what scenario would this page not exist?
t0mdavid-m
reviewed
Jul 1, 2026
| import streamlit as st | ||
| st.success("✅ Report ready. Next step:") | ||
| try: | ||
| st.page_link("content/ptxqc_results.py", label="**4. Report**", icon="📊") |
t0mdavid-m
reviewed
Jul 1, 2026
| import streamlit as st | ||
| st.success("✅ Data uploaded. Next step:") | ||
| try: | ||
| st.page_link("content/ptxqc_configure.py", label="**2. Configure**", icon="⚙️") |
t0mdavid-m
reviewed
Jul 2, 2026
| bufsize=1, # Line buffered | ||
| universal_newlines=True | ||
| ) | ||
| except (FileNotFoundError, OSError) as e: |
…llback
- Rewrite test_gui.py to boot app.py + switch_page so pages run inside the
real st.navigation shell. Standalone AppTest.from_file skipped navigation,
which made st.page_link raise KeyError('url_pathname') only in tests and
hid genuinely broken links behind the try/except.
- Remove the now-unnecessary try/except around st.page_link in the upload,
configure, and run pages.
- Revert CommandExecutor.run_command to plain subprocess.Popen (now identical
to template/main); the missing-Rscript case is already handled one layer up
in Workflow.execution().
- Add ADR 0001 (GUI tests drive real navigation) and 0002 (keep the inherited
template layer app-agnostic).
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update installation instructions for local deploy
user convenience features (selective upload of Dir files) and ernumer…
…ation of steps (1. Upload, 2) configure....)