Skip to content

feat: resolve #33, #42, #43 and fix macOS compilation - #56

Open
Lakshayg136 wants to merge 2 commits into
Bimbok:mainfrom
Lakshayg136:resolve-issues-33-42-43
Open

Lakshayg136 wants to merge 2 commits into
Bimbok:mainfrom
Lakshayg136:resolve-issues-33-42-43

Conversation

@Lakshayg136

Copy link
Copy Markdown

Summary

  • What does this PR change?
    • Adds the -a / --about CLI flags to print quick project information.
    • Adds a friendly empty state message (󰉖 This directory is empty) when empty directories are loaded in panes or previews.
    • Adds real-time folder/file count statistics in the bottom status bar (📁 X folders | 📄 Y files).
    • Resolves macOS compile-time errors by conditionally compiling Linux-specific inotify modules and casting standard write time values.
  • Why is this change needed?
    • Allows users to check project details directly from the CLI.
    • Resolves visual confusion where empty folders appeared completely blank.
    • Increases navigational awareness by giving users immediate directory statistics.
    • Restores portability by enabling the codebase to compile on macOS.

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Performance improvement
  • Documentation update
  • CI/CD change
  • Other

Changes Made

  • src/main.cpp: Implemented the -a / --about options and updated the helper details in the -h / --help option menu.
  • src/utils.cpp: Cast last_write_time epoch count to long long to prevent compiler type ambiguity on macOS.
  • src/file_manager.h:
    • Wrapped sys/inotify.h and the inotify init/worker/watch updates in #ifndef __APPLE__ blocks.
    • Updated drawPane() and drawPreview() to output 󰉖 This directory is empty centered in empty directories using cyan.
    • Counted folders and files in currentFiles dynamically and printed them in the status bar while adjusting the path width to prevent overflows.

Testing

  • Built locally
  • Ran ./fyzenor --version
  • Ran ./fyzenor --help
  • Tested interactive behavior manually

Environment

  • OS: macOS (Darwin)
  • Terminal emulator: Terminal / Kitty
  • Shell: zsh

Screenshots or Terminal Output

$ ./fyzenor --about
Fyzenor - The Blazing Fast, Modern C++ Terminal File Manager Version: 3.0.0

$ ./fyzenor --help
Fyzenor - The Blazing Fast, Modern C++ Terminal File Manager
Usage: fyzenor [options]
Options:
  -v, --version         Show version information
  -a, --about           Show about information
  -h, --help            Show this help message

@Lakshayg136

Copy link
Copy Markdown
Author

Hi @Bimbok,
I have updated the branch with the latest changes from main and resolved the issues (#33, #42, and #43) along with the macOS compilation blocker.

Could you please approve/run the workflow checks, review the PR, and add the gssoc label?

Thank you!

@Lakshayg136
Lakshayg136 force-pushed the resolve-issues-33-42-43 branch from d7d09e7 to 18e5475 Compare July 21, 2026 06:49
@Lakshayg136

Copy link
Copy Markdown
Author

Hi @Bimbok, I have resolved the merge conflicts with main. The PR is clean and ready for review whenever you get a chance!
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant