SBAI-7198: pin frontend nanoid >= 3.3.18 - #471
Open
BizaNator wants to merge 1 commit into
Open
Conversation
postcss (via Vite) already allowed ^3.3.16; no parent release requires 3.3.18, so pin the floor with an npm override. Lockfile now resolves 3.3.18. Node tests assert the resolved version and that a size-0 custom generator returns without hanging.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves SBAI-7198.
What
npm auditreported GHSA-2v37-7h3g-55p8 (High): transitivenanoid<3.3.18can loop forever in a custom generator whensizeis 0.Parent
npm ls nanoid→vite@6.4.3→postcss@8.5.25→nanoid. Latest postcss still depends on^3.3.16/^3.3.17— no parent bump forces 3.3.18. Override is the justified fallback.Change
frontend/package.jsonoverrides.nanoid = ^3.3.18nanoid@3.3.18src/security/nanoid-resolution.test.ts— lockfile version floor + size-0 custom generator does not hangNo product import of nanoid (build-time via Vite/postcss only).
Verify
npm audit→ 0 vulnerabilitiesnpm run test:node→ 27/27tsc --noEmitcleanOut of scope
website/package-lock.jsonstill resolvesnanoid@3.3.12. Same advisory, different package — follow-up, not this ticket.Respect LoreGUI merge freeze: do not self-merge.