fix: Windows Store Codex support - AUMID, process lifecycle, protocol proxy robustness#613
Open
congxb wants to merge 1 commit into
Open
fix: Windows Store Codex support - AUMID, process lifecycle, protocol proxy robustness#613congxb wants to merge 1 commit into
congxb wants to merge 1 commit into
Conversation
… proxy robustness - Fix AUMID generation for MSIX packages (use PackageFullName!App instead of reconstructing) - Add graceful fallback to direct Codex.exe execution on packaged activation failure - Configure HTTP client timeout/keepalive/pool for streaming SSE responses - Add relay_base_url() fallback from upstreamBaseUrl in protocol proxy - Add process lifecycle CDP health monitor to prevent early process exit - Add robust error handling with catch-all blocks in proxy handlers - Restart Helper after wait_for_codex_exit shuts it down
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes 4 issues that prevent CodexPlusPlus from working with the Windows Store (MSIX) version of Codex...
Changes
Fix 1: Correct AUMID generation (app_paths.rs)
packaged_app_user_model_id() incorrectly stripped version/architecture from MSIX package name.
Fix 2: Graceful fallback on activation failure (launcher.rs)
When AUMID activation fails, fall back to direct Codex.exe execution.
Fix 3: HTTP client timeout config (http_client.rs)
proxied_client() had no timeout/keepalive/pool config. Streaming SSE over 30s would timeout.
Fix 4: Protocol proxy base_url fallback (protocol_proxy.rs)
Added relay_base_url() helper that falls back to upstreamBaseUrl when base_url is empty.
Also switched open_chat_completions_proxy_request to proxied_client().
Fix 5: Process lifecycle - CDP health monitor (main.rs + launcher.rs)
Codex.exe is a broker - wait_for_codex_exit() returns immediately AND shuts down Helper.
Fix: restart Helper after wait, enter CDP health-check loop.
Fix 6: Robust error handling (launcher.rs)
Catch-all blocks in proxy handlers write 500 responses instead of closing TCP connection.
Files Changed
Tested on: Windows 11 Pro 10.0.26200 with Codex OpenAI.Codex_26.601.2237.0_x64__2p2nqsd0c76g0