fix: correct AUMID generation for Windows Store Codex + fallback to direct execution#591
Open
congxb wants to merge 1 commit into
Open
fix: correct AUMID generation for Windows Store Codex + fallback to direct execution#591congxb wants to merge 1 commit into
congxb wants to merge 1 commit into
Conversation
…irect execution - app_paths.rs: Use full package_name + '!App' instead of splitting to preserve version and architecture in AUMID - launcher.rs: Match on activate_packaged_app result and fall back to direct Codex.exe execution when AUMID activation fails - This fixes the bug where Windows Store/MSIX version of Codex could not be launched by CodexPlusPlus due to incorrect AUMID format Fixes BigPizzaV3#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the bug where CodexPlusPlus cannot launch the Windows Store / MSIX version of Codex due to incorrect AUMID generation.
Problem
The function in incorrectly generates the AUMID by splitting the package name and only keeping the identity prefix and publisher ID, losing the version and architecture parts.
Changes
1.
Use full instead of reconstructing from parts:
2.
Add fallback to direct execution when AUMID activation fails:
Verification
Related