Skip to content

Return null for source audio with 0 length #1215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsarabia merged 1 commit into from
Mar 2, 2026
Merged

Return null for source audio with 0 length #1215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ...otlin/org/wycliffeassociates/otter/common/domain/resourcecontainer/SourceAudioAccessor.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,9 @@ class SourceAudioAccessor(

val oratureAudioFile = OratureAudioFile(file)
val size = oratureAudioFile.totalFrames

if (size == 0) return null

SourceAudio(file, 0, size)
} else {
null
Expand All @@ -142,6 +145,9 @@ class SourceAudioAccessor(
val nextMarker = if (chunks.lastIndex > markerIndex) chunks[markerIndex + 1] else null
val start = marker.location
val end = nextMarker?.location ?: oratureAudioFile.totalFrames

if (end - start == 0) return null

return SourceAudio(file, start, end)
}
}
Expand All @@ -161,6 +167,9 @@ class SourceAudioAccessor(
val nextMarker = if (verses.lastIndex > markerIndex) verses[markerIndex + 1] else null
val start = marker.location
val end = nextMarker?.location ?: oratureAudioFile.totalFrames

if (end - start == 0) return null

return SourceAudio(file, start, end)
}
}
Expand Down
Loading