Support Scripture Burrito RC - #1212
Draft
jsarabia wants to merge 39 commits into
Draft
Conversation
Adds filtering out content not matching a particular chapter of u23003 so that those sections can be omitted from reading (needed as orature markers only mark the starting location and don't save the end location). Fixes an issue with Source Audio where a media format will be selected because of a template entry in the media manifest, and not trying others even if the matching file is not there. This will continue to match other media files until one is found or the search is exhausted.
Book numbers might not have be offset by 1 for the nt, so make sure to map this to the ufw order
A timing file may have a docid with a path relative to the root of the burrito instead of just the audio file name, as such we need to try both to find the timing
… writing fails delaying creating the file so that the BurritoAlignmentMetadata can do it (which it was already doing
Invalid references do not return null exactly, so these tests are moot
Nothing in this test prior to this line delete anything, so this assertion makes no sense
Part of the new standard places an optional properties field on ingredients
If a versification file is not found, currently import will fail due to an exception with trying to access a null file. Rather, we should return Maybe.empty, as the maybe is meant to imply the return value may or may not exist.
Relaxes the check in the event that the filename being looked for doesn't contain the full path of the docid in the timing file
Prevent some crashes if a 0 length source audio is loaded for translation. Returns null as a 0 length file for source audio is effectively equivalent to not being found at all. This prevents crashing on the consume page if a source audio file is empty.
These don't have repos and just 404. As a result, the task doesn't cache and the download of all GL sources happens every time you build/run the app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supports Scripture Burrito from the Scripture Burrito Audio Working Group. This includes support for audio scripture burritos as well as Scripture Burrito Wrappers.
Merges in various in house libraries.
This change is