ci: add build-only GitHub Actions workflow (Node 20/22 matrix) - #3
Merged
Conversation
Adds .github/workflows/ci.yml gating on `npm run build` (tsc) across a 20.x/22.x Node matrix, triggered on PRs and pushes to main scoped to TS and package files. Build-only for now: the package has no test script yet. Node 18 is intentionally excluded (EOL 2025-04-30), mirroring the matrix convention already used in the sibling nyc-charter-laws-rules repo. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Add `.github/workflows/**` to the pull_request and push path filters so edits to the workflow itself re-trigger it, and add a permanent `workflow_dispatch` trigger for on-demand re-runs. Without the path addition, the PR that introduces this workflow never fires it (the diff touches only files outside the filter), so the gate was never actually exercised on GitHub Actions. Mirrors the fix landed in nyc-council-mcp PR #6. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
Author
|
CI workflow verified with a real triggered run. The workflow's own Pushing that change fired a real
Build-only gate (no test script yet); both matrix cells green on the CI runner, confirming the compile passes in the runner environment, not just locally. |
noneck
added a commit
that referenced
this pull request
Jul 1, 2026
…) (#4) Resolves the high-severity npm audit finding surfaced during CI setup (PR #3). hono is pulled in transitively via @modelcontextprotocol/sdk; the installed 4.12.21 fell in the vulnerable range (<=4.12.24). npm audit fix bumps only the lockfile-pinned hono to 4.12.27, a patch-level bump within hono 4.x. No manifest change; the SDK API is untouched. npm ci + npm run build pass; npm audit reports 0 vulnerabilities. Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
noneck
added a commit
that referenced
this pull request
Jul 6, 2026
…refresh - Bump package.json/lockfile to 1.0.2. - Server reads its version from package.json via createRequire instead of a hardcoded string. - CHANGELOG: move Unreleased items into 1.0.2 (double-encoding fix #6, SoQL escaping + enum enforcement + NY-timezone today + error detail #7, hono bump #4, CI #3, release automation #8). - README: Claude Code config updated to .mcp.json / claude mcp add; add npm test instructions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
noneck
added a commit
that referenced
this pull request
Jul 6, 2026
* fix: SoQL escaping, NY-timezone today, error detail - Add soqlString() helper (quote-doubling) and use it in every $where builder: getNoticesByType, getNoticesByAgency, getNoticesByDateRange. - Validate notice_type with z.enum (mirrors the advertised tool enum, now derived from a single NOTICE_TYPES constant) and date params as YYYY-MM-DD. - getOpenSolicitations: compute "today" in America/New_York (nyToday()) instead of UTC, which dropped same-day deadlines after 8pm ET. - Include the (truncated, 300-char) Socrata error body in thrown errors. - Live-verified 2026-07-06: dataset's distinct type_of_notice_description values exactly match the hardcoded lists/enum (10 values, plus null rows); all start_date values are midnight, so the <= end bound is correct (documented in code). - Tests: escaping regressions, injected-clock NY-date checks (EDT/EST), error-body inclusion + truncation. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> * chore(release): 1.0.2 — version from package.json, changelog, README refresh - Bump package.json/lockfile to 1.0.2. - Server reads its version from package.json via createRequire instead of a hardcoded string. - CHANGELOG: move Unreleased items into 1.0.2 (double-encoding fix #6, SoQL escaping + enum enforcement + NY-timezone today + error detail #7, hono bump #4, CI #3, release automation #8). - README: Claude Code config updated to .mcp.json / claude mcp add; add npm test instructions. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds
.github/workflows/ci.yml— the first CI gate for this repo.The workflow:
pull_requestandpushtomain, path-scoped to**/*.ts,package.json, andpackage-lock.json(no runs for docs-only or unrelated changes).permissions: contents: read(least-privilege).buildjob across a Node 20.x / 22.x matrix withfail-fast: false, usingactions/setup-node@v4with npm caching.npm ci(clean, locked install) thennpm run build(tsc).Why
The six BetaNYC public MCP repos have had no CI test gate, unlike the Python tree in the main workspace. This adds a minimal compile gate so a TypeScript break can't merge silently.
Build-only, pending test coverage. This package has no
testscript yet, so the gate covers the build alone. When a test script is added, anpm teststep should be appended to this workflow. This is noted in a header comment in the workflow file.Node matrix rationale
package.jsondeclaresengines.node ">=18". The matrix tests both ends of the actively-maintained range — 20.x and 22.x. Node 18 is intentionally excluded (End-of-Life 2025-04-30). This mirrors the matrix convention already established in the siblingnyc-charter-laws-rulesrepo, keeping CI consistent across BetaNYC's MCP repos.Verification
npm ci+npm run buildrun locally: build exits 0.Scope
CI setup only. No source, dependency, or config changes.