test(smoke): add install smoke, migrate to the shared org workflow - #2065
Merged
Conversation
duncdrum
force-pushed
the
dp-install-smoke
branch
from
July 20, 2026 10:53
33c863b to
c557f6f
Compare
duncdrum
marked this pull request as ready for review
July 20, 2026 11:49
build.xml's ant token-replacement regex (version=".*") was greedy and silently dropped the adjacent spec attribute from the built expath-pkg.xml. Also stops test/*.bats from shipping inside the built xar.
Replaces the local job + bats copy with a call into BetaMasaheft/.github's install-smoke.yml reusable workflow (BetaMasaheft/.github#10, #11, #12) - dependency-aware install via xst, shared 8-check bats suite, so a future fix lands once instead of once per repo. Also scopes the push trigger to master/main so a PR branch push doesn't double-fire this workflow via both push and pull_request.
duncdrum
force-pushed
the
dp-install-smoke
branch
from
July 21, 2026 13:27
d364798 to
9fb7ee8
Compare
duncdrum
changed the title
DrRataplan
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an install smoke (jinks
01-smoke.batstemplate) that actually autodeploys the built xar into a clean eXist - this repo's CI was validation-only (TEI schema) with no check that the package installs at all.Running it immediately found a real bug: the
templatesant target's version-tokenreplaceregexis greedy (version=".*") and swallows the adjacentspec="1.0"attribute since they share a line, corrupting every ant-built xar's expath-pkg.xml (a bare eXist then refuses to install it: "The element does not have an attribute spec"). Not previously caught because every current consumer (the old monolith Dockerfile, the new data.Dockerfile) zips the raw repo directly and never runsant. Fixed by anchoring the regex to the nearest quote instead of matching greedily to end-of-line.Since then, migrated onto BetaMasaheft/.github's shared
install-smoke.ymlreusable workflow (BetaMasaheft/.github#10, #11, #12) instead of a local job + bats copy - two real bugs found in that local copy (agrep -c 'healthy'substring match against Docker's(unhealthy)status; an overly strict exact-count assertion on the package-deployment log check) had to be hand-patched across all 10 sibling repos separately before centralizing, which is exactly the problem the shared workflow now solves. Also scopes thepushtrigger tomaster/mainso a PR branch push doesn't double-fire this workflow via bothpushandpull_request.Verified end-to-end in real CI (ant build -> xst install -> shared bats suite) before merging.
Refs BetaMasaheft/BetMas#122