Skip to content

Implemented HMAC-SHA256 authentication and per-IP limits #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ashboundscar wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implemented HMAC-SHA256 authentication and per-IP limits #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 37 additions & 0 deletions src/game/client/components/bestclient/voice/server.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@
#include <base/system.h>
#include <base/os.h>

#include <engine/shared/bestclient_indicator_protocol.h>

#include <algorithm>
#include <array>
#include <chrono>
Expand All @@ -15,8 +17,10 @@
namespace
{
constexpr int MAX_CLIENTS = 256;
constexpr int MAX_CLIENTS_PER_IP = 4;
constexpr int64_t CLIENT_TIMEOUT_SECONDS = 30;
constexpr int64_t PEER_LIST_SAFETY_BROADCAST_SECONDS = 5;
constexpr int64_t MAX_AUTH_TIME_DIFF = 300; // 5 minutes

constexpr float PACKETS_PER_SECOND = 90.0f;
constexpr float PACKETS_BURST = 140.0f;
Expand Down Expand Up @@ -109,6 +113,15 @@ CClientSlot *AcquireClientSlot(std::array<CClientSlot, MAX_CLIENTS> &aSlots, con
return pSlot;
}

int IpCount = 0;
for(const auto &Slot : aSlots)
{
if(Slot.m_Used && net_addr_comp(&Slot.m_Addr, &Addr, true) == 0)
IpCount++;
}
if(IpCount >= MAX_CLIENTS_PER_IP)
return nullptr;

for(auto &Slot : aSlots)
{
if(!Slot.m_Used)
Expand Down Expand Up @@ -277,6 +290,14 @@ int main(int argc, const char **argv)
uint16_t NextClientId = 1;
int64_t LastPeerListBroadcast = 0;

const char *pAuthKey = getenv("BC_VOICE_AUTH_KEY");
if(!pAuthKey || pAuthKey[0] == '\0')
{
// Fallback to the known default key if not provided via env
pAuthKey = "bcv4-red-171-vgise-dgsk";
}
log_info("voice-server", "using auth key: %s...", std::string(pAuthKey).substr(0, 4).c_str());

while(true)
{
using namespace std::chrono_literals;
Expand Down Expand Up @@ -323,6 +344,22 @@ int main(int argc, const char **argv)
continue;
}

uint64_t AuthTimestamp = 0;
if(Offset < DataSize && !BestClientVoice::ReadU64(pRawData, DataSize, Offset, AuthTimestamp))
continue;

// Security Checks
const int64_t ServerTimestamp = (int64_t)time_timestamp();
if(AuthTimestamp == 0 || (int64_t)AuthTimestamp < ServerTimestamp - MAX_AUTH_TIME_DIFF || (int64_t)AuthTimestamp > ServerTimestamp + MAX_AUTH_TIME_DIFF)
{
continue;
}

if(!BestClientIndicator::ValidateHmacSha256(pAuthKey, pRawData, DataSize))
{
continue;
}

bool NewSlot = false;
CClientSlot *pSlot = AcquireClientSlot(aSlots, From, RoomKey, GameClientId, NextClientId, Now, NewSlot);
if(!pSlot)
Expand Down
Loading