Skip to content

TimeSeriesParameter Fix#486

Merged
dfremont merged 1 commit into
mainfrom
ExternalParamsFix
Jul 5, 2026
Merged

TimeSeriesParameter Fix#486
dfremont merged 1 commit into
mainfrom
ExternalParamsFix

Conversation

@Eric-Vin

@Eric-Vin Eric-Vin commented Jul 5, 2026

Copy link
Copy Markdown
Collaborator

Description

Fix TimeSeriesParameter resetting across simulations

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

NA

@dfremont dfremont merged commit 2fc1634 into main Jul 5, 2026
28 of 37 checks passed
@dfremont dfremont deleted the ExternalParamsFix branch July 5, 2026 22:38
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.82%. Comparing base (8257147) to head (136fda4).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/scenic/core/external_params.py 0.00% 4 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #486      +/-   ##
==========================================
- Coverage   89.87%   89.82%   -0.06%     
==========================================
  Files          48       48              
  Lines       13346    13350       +4     
==========================================
- Hits        11995    11991       -4     
- Misses       1351     1359       +8     
Files with missing lines Coverage Δ
src/scenic/core/external_params.py 75.75% <0.00%> (-1.57%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants