Repository navigation
Description
Follow-up of spec 004 (#4): dataset-names replaces its own copies of the generic source code with the benchcommons-tools-dataset package. The dataset-names side (spec, plan, code) is written in dataset-names; this issue tracks it from tools-dataset.
Contract to adopt: docs/specs/004-source-toolkit/spec.md in this repo, at tag v0.1.0.
-
Tag
v0.1.0of tools-dataset exists (created after spec 004 merges) -
dataset-names spec for the adoption, linking to spec 004 here instead of redefining it
-
Dependency declared as in ADR 0004 of this repo (
[tool.uv.sources]git source pinned to the tag) -
src/namescommons/cache.pyreplaced bydatasettool.sources.cache(User-Agent of dataset-names passed explicitly) -
src/namescommons/spreadsheet.pyreplaced bydatasettool.sources.spreadsheet -
Generic part of
src/namescommons/adapters/__init__.pyreplaced bydatasettool.sources.adapters;RawRecordandRawLinkstay in dataset-names;check_adaptercalled withoptional=("links",) -
src/namescommons/sources.pyrebuilt ondatasettool.sources.registrywith its own fields (country,count_type,primary,suppression,uniform_case), its accepted licences (ADR 0001 and 0004 of dataset-names) and the one-primary check -
src/namescommons/manifest.pyusesdatasettool.filesfor checksums and CSV row counts -
Ported tests removed from dataset-names only after the equivalents pass here (list them before deleting)
-
Do not assert on the order of lines inside a multi-error registry message: the toolkit checks
retrievedandadapterbefore the dataset fields (country,count_type,primary,suppression,uniform_case), while dataset-names checked them in between (plan 2.4 of spec 004); the set of messages is the same -
The cache now refuses source ids outside
[a-z0-9]+(-[a-z0-9]+)*and unsafe file names (ValueError), as dataset-names' registry already does
Done in BenchCommons/dataset-names#41 (spec 007, ADR 0013): every item above is implemented and verified there (identical outputs on the fixtures and on the full real cache). Follow-ups: #9 (the cache refuses symlinked entries, found during the adoption) and BenchCommons/dataset-names#40 (message language).
Activity
docs: fix the registry order note, split the placement ADR, English t…
docs(toolkit): document the tools-dataset dependency
matbrgz commentedon Oct 12, 2026
All checklist items are implemented in BenchCommons/dataset-names#41 (spec 007). Closing as instructed; reopen if that PR is not merged as is.
matbrgz commentedon Oct 12, 2026
Reaberta até o merge de BenchCommons/dataset-names#41, que faz a adoção.
matbrgz commentedon Oct 12, 2026
Adoção concluída em BenchCommons/dataset-names#41.