Add PR quality contract#5
Open
BenSheridanEdwards wants to merge 2 commits into
Open
Conversation
Fallow audit reportFound 1 finding. Details
Generated by fallow. |
Fallow audit report0 inline findings selected for GitHub review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why does this feature exist?
Agents need a repository-local quality contract so completed work presents consistent implementation evidence at review time.
What changed?
.github/pull_request_template.mdwith the required review sections..agents/definition_of_done.mddefining completed-PR requirements..agents/skills/pr-quality-contract/SKILL.mdso agents have a repository-local process for this gate.Behavioural Proof (with video and screenshots)
python3 .agents/verify_quality_contract.py <worktree>run locally before commit; verifier was not committed.Verification Summary
git diff --checkpython3 .agents/verify_quality_contract.py <worktree>git diff --check: passedquality contract verifier passed