chore(config): fix pre-push to guard by push destination#21
Merged
Conversation
…anch The hook keyed off the checked-out branch, so it blocked every push made while on main or release (including unrelated branch deletions) and let a direct push to a protected branch through when it came from a differently-named local branch. Read the refs git streams on stdin and refuse only when the push destination is main or release; deletions and every other push are allowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the pre-push hook to gate on the ref being pushed instead of the checked-out branch. Previously any push made while on main or release was blocked (including branch deletions), and a direct push to a protected branch from a differently-named local branch slipped through. It now reads git's stdin ref list and refuses only pushes whose destination is main or release, allowing deletions and all other pushes. One of six repos sharing this hook.