feat(sniffs): allow // nosemgrep directives in comment-style sniffs#19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Exempts
nosemgrepdirective comments from the BSU comment-style sniffs, the same wayphpcs:,@codeCoverageIgnore, and@phpstanare already exempt.SingleLineCommentSniff(own-line comments) andInlineCommentSniff(trailing comments) now skip any comment containingnosemgrep, so// nosemgrep: <rule-id> -- reasonno longer gets flagged or auto-converted to a block comment.// nosemgrep: ...) without the comment tripping the standard's "use /* */" / "use PHPDoc" rules.Added PASS fixtures for both the standalone and trailing forms;
npm run lintandnpm testare green.