fix: stream partial line output, no wait for sentinel#35
Merged
Conversation
Codecov Report❌ Patch coverage is
🚀 New features to boost your workflow:
|
scanToSentinel read line-by-line, so newline-less output (print w/o newline, \r progress bar) buffered til eval end — background output file empty whole time, then dumped at once. now read byte-wise: drain buffered burst, emit safe prefix immediately, hold back only trailing bytes that could start the sentinel. byte-wise read changed python startup-stderr chunk boundaries, exposing a windows-only prompt leak (first eval replays captured startup chunks as its stderr). root cause: runtime loaded over stdin AFTER the REPL already printed default >>> prompts. fix at source — load runtime via python -i -c so it sets ps1/ps2="" and the no-op displayhook before the interactive loop prints any prompt. no prompts ever emitted; deletes all prompt-stripping code. tests: stream partial line, hold sentinel prefix, lines+tail, eof flush.
Beforerr
force-pushed
the
push-oznuruurxzmu
branch
from
6075439 to
5f873fb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
scanToSentinel read line-by-line. print no newline + \r progress bar buffer
til eval end. background output file empty whole time, then dump all at once.
now read byte-wise, drain buffered burst, emit safe prefix now. hold back only
trailing bytes that could start sentinel. byte-wise read so \r/print stream live.
add session_test.go: stream partial, hold sentinel prefix, lines+tail, eof flush.