Skip to content

chore: ensure deterministic ordering in product ranking queries #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
FAnagua merged 1 commit into from
Jun 3, 2026
Merged

chore: ensure deterministic ordering in product ranking queries #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/java/com/bazaar/orders/repository/OrderItemRepository.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ ORDER BY SUM(oi.quantity) DESC
value = "SELECT new com.bazaar.orders.dto.catalog.ProductRankingResponseDTO(oi.productId, SUM(oi.quantity), SUM(oi.price * oi.quantity)) "
+ "FROM OrderItem oi " + "WHERE oi.order.orderPayment.createdAt >= :startDate "
+ "AND oi.order.orderPayment.orderPaymentStatus = :status " + "GROUP BY oi.productId "
+ "ORDER BY SUM(oi.quantity) DESC",
+ "ORDER BY SUM(oi.quantity) DESC, oi.productId DESC",
countQuery = "SELECT COUNT(DISTINCT oi.productId) "
+ "FROM OrderItem oi "
+ "WHERE oi.order.orderPayment.createdAt >= :startDate "
Expand All @@ -119,7 +119,7 @@ ORDER BY SUM(oi.quantity) DESC
AND op.orderPaymentStatus = :status
AND oi.category IN :categories
GROUP BY oi.productId
ORDER BY SUM(oi.quantity) DESC
ORDER BY SUM(oi.quantity) DESC, oi.productId DESC
""",
countQuery = """
SELECT COUNT(DISTINCT oi.productId)
Expand Down
Loading