Skip to content

added NoisyOr.java and changed APPROXIMATE_ZERO in util.java#332

Open
teeranan wants to merge 2 commits into
BayesianLogic:masterfrom
teeranan:master
Open

added NoisyOr.java and changed APPROXIMATE_ZERO in util.java#332
teeranan wants to merge 2 commits into
BayesianLogic:masterfrom
teeranan:master

Conversation

@teeranan

@teeranan teeranan commented Dec 8, 2014

Copy link
Copy Markdown

No description provided.

@cberzan

cberzan commented Dec 17, 2014

Copy link
Copy Markdown
Contributor

@teeranan

  1. Please add a description and explain why changing APPROXIMATE_ZERO was necessary. This is so others seeing this PR can understand what's happening.

  2. NoisyOr distrib needs a unit test. See TestUnivariateGaussian for an example.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get rid of the extra whitespace here, so that the commit isn't polluted by mere whitespace changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants