Skip to content

adding syntax support for externally defined distributions and functions#307

Open
lileicc wants to merge 4 commits into
masterfrom
adding-extern-syntax
Open

adding syntax support for externally defined distributions and functions#307
lileicc wants to merge 4 commits into
masterfrom
adding-extern-syntax

Conversation

@lileicc

@lileicc lileicc commented Sep 24, 2014

Copy link
Copy Markdown
Contributor

@cberzan @jxwuyi @datang1992 @tejasvsrinivasan

distribution Real Gaussian(Real mu, Real variance);
extern Real abs(Real x);

@lileicc

lileicc commented Sep 24, 2014

Copy link
Copy Markdown
Contributor Author

@cberzan
would you please check why it fails the test?

@lileicc

lileicc commented Sep 24, 2014

Copy link
Copy Markdown
Contributor Author

solved compilation issue.

@lileicc

lileicc commented Sep 27, 2014

Copy link
Copy Markdown
Contributor Author

I have another thought about extern.

extern might not be necessary. Since we can already write,

fixed Real abs(Real abs) = blog.model.AbsInterp();

Or we should even simplify it to be

fixed Real abs(Real abs) = blog.model.AbsInterp;

@lileicc

lileicc commented Sep 29, 2014

Copy link
Copy Markdown
Contributor Author
extern Real abs(Real x);
distribution Real Gaussian(Real mu, Real variance);

@cberzan

cberzan commented Oct 2, 2014

Copy link
Copy Markdown
Contributor

@lileicc Are you still changing this, or should I review?

@lileicc

lileicc commented Oct 2, 2014

Copy link
Copy Markdown
Contributor Author

This is not ready for review yet. Since it needs support in Semant.java.

On Wed, Oct 1, 2014 at 5:24 PM, cberzan notifications@github.com wrote:

@lileicc https://github.com/lileicc Are you still changing this, or
should I review?


Reply to this email directly or view it on GitHub
#307 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants