remove default memory setting#285
Conversation
|
@jxwuyi, @datang1992 |
|
@datang1992 |
|
@datang1992 |
|
@datang1992 Well, -J is a scala option which means to take the following option to be the java option. I am not sure if scala does some checking for this. You might have a try. |
…d as the first parameter.
|
@datang1992 |
|
I just find that your original code doesn't work since that the memory won't be set exactly in Windows if you just type iblog -J-Xmx*** in your original version. But it works on Linux/Mac. I don't know the reason. But I tried on my laptop that writing in this way will work. |
|
If you think there is something wrong with the pull request, I could create a new pull request from master and add the two modifications in the request. @jxwuyi |
|
I haven't set up continuous integration correctly as of today, so ignore the red crossings for now.
|
|
@chrisgioia64 What caused this crossing? |
|
I could try do find out the reason. Could you have a try for both of the versions and try to see that if it is the case that the original one fails while the new one works? @jxwuyi |
|
@jxwuyi For more information, refer to this issue: You can see the stack trace for one of the commits here: Basically, it clones the repo, does some preprocessing, and runs a few test Do either of you understand how sbt/sbt test works? I don't know what tests On Tue, Jul 22, 2014 at 9:48 PM, jxwuyi notifications@github.com wrote:
|
|
@datang1992 Sure I will check it out tmmr. |
|
Donot worry about the test for now. Once Chris finished, it will disappear. Lei On Tue, Jul 22, 2014 at 11:09 PM, jxwuyi notifications@github.com wrote:
|
@datang1992 @lileicc
currently in the new version, there is no memory setting by default.