test/ci: repair compliance suite; demote weekly-compliance to placeholder until 0.2.0 on CRAN#143
Merged
Merged
Conversation
The workflow called remotes::install_github("MaartenMarsman/mixedGM") but
setup-r-dependencies did not install remotes, so the step failed immediately
with 'there is no package called remotes' (weekly job red since April). Add
remotes to extra-packages, matching the nightly job's devtools pattern.
…tself Dispatching the job revealed two more problems past the remotes fix: - The mixedGM install (remotes::install_github MaartenMarsman/mixedGM) 404s: the repo is inaccessible to the repo-scoped CI token, and tests/compliance/ does not use mixedGM at all (it is only referenced by skip-guarded validation helpers in the regular suite). Remove the step (and the remotes dep added for it). - test_compliance.R does library(bgms), but setup-r-dependencies installs only dependencies, not the package. Add extra-packages: local::. so bgms is installed. This leaves: checkout -> setup-r -> deps+bgms -> (gen fixtures if missing) -> run bitwise compliance.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
==========================================
- Coverage 87.75% 87.74% -0.01%
==========================================
Files 87 87
Lines 12867 12862 -5
==========================================
- Hits 11291 11286 -5
Misses 1576 1576 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The weekly-compliance job had been red since April. Investigating it surfaced a chain of issues — fixed the real ones, and demoted the CI job to a placeholder because bitwise-in-CI is fundamentally unworkable until there's a matching CRAN release.
Genuine fixes (kept)
remotesmissing, a 404ing/unusedmixedGMinstall, andlibrary(bgms)with the package never installed. (Moot now that the job is a placeholder, but the diagnosis drove the rest.)fit$posterior_coclustering_matrix(renamed →posterior_mean_coclustering_matrixin 0.2.0) andfit$posterior_mean_indicatorfor bgmCompare (gone; bgmCompare has onlyposterior_summary_indicator). Updated to the current API. (Confirmed these were renames, not removals, and not from this session's refactors.)generate_fixtures.Randtest_compliance.Rduplicated the config matrix in different formats and had diverged (test side pinned the CRAN-eratarget_accept=0.6/0.65; generator used the default). Extracted a sharedtests/compliance/config_defs.Rboth source, withtarget_acceptpinned explicitly per config (NUTS 0.80, adaptive-metropolis 0.44).Why the CI job is now a placeholder
Bitwise compliance against committed fixtures can't run in CI: NUTS leapfrog trajectories are chaotically FP-sensitive, so fixtures reproduce bitwise only on the machine that generated them — verified: ubuntu CI 0/32, macOS CI 8/32, vs 32/32 on the generating machine. So the bitwise check is inherently local (
test_compliance.R, documented LOCAL-ONLY).weekly-compliance.yamlis reduced to a green placeholder that documents the planned replacement: once 0.2.0 is on CRAN, install the CRAN release + dev build on one runner and diff them bitwise on the fly — same FP environment, so differences are real code changes; platform-independent; no committed fixtures.Not in scope