[codex] Isolate daily summary Redis import#7947
Open
tianmind-studio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redis.Redisinsidetest_daily_summary_regenerate.pyso the daily summary regenerate tests collect in lightweight Windows backend environments without the Redis SDK installed.backend/databasepackage path if another stub-heavy test has already left a lightweightdatabasepackage insys.modules.database._client.dbonly when a previous test already installed a_clientstub, keeping normal imports on the real module path.Why
test_daily_summary_regenerate.pyverifies thatupdate_daily_summarypreserves the existing document ID during regeneration. It does not exercise Redis, but importingdatabase.daily_summariesalso importsdatabase.redis_db, which imports the optional Redis SDK at module import time. On this Windows lightweight backend venv, collection failed before the regression assertions could run:Running after another lightweight test can also leave a stubbed
databasepackage and_clientmodule insys.modules; the test now restores the package path and fills the existing client stub with the minimaldbattribute needed bydatabase.daily_summaries.Validation
python -m pytest backend\tests\unit\test_daily_summary_regenerate.py --collect-only -q --tb=shortpython -m pytest backend\tests\unit\test_daily_summary_regenerate.py -q --tb=shortpython -m pytest backend\tests\unit\test_action_item_date_validation.py backend\tests\unit\test_daily_summary_regenerate.py -q --tb=shortpython -m pytest backend\tests\unit\test_daily_summary_regenerate.py backend\tests\unit\test_action_item_date_validation.py -q --tb=shortpython -m black --line-length 120 --skip-string-normalization backend\tests\unit\test_daily_summary_regenerate.pypython -m py_compile backend\tests\unit\test_daily_summary_regenerate.pygit diff --checkscripts\pre-commit