[codex] Isolate conversation count FieldFilter import#7946
Open
tianmind-studio wants to merge 1 commit into
Open
[codex] Isolate conversation count FieldFilter import#7946tianmind-studio wants to merge 1 commit into
tianmind-studio wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldFilterfallback intest_conversations_count.pywhengoogle.cloud.firestore_v1is unavailable.FieldFilterwhen the dependency is installed.google.cloud.firestore_v1stub insys.modulesbefore this file is collected.Why
This test validates query-building logic using only the
field_pathandvalueattributes ofFieldFilter. On a lightweight Windows backend environment, collection failed before any assertions ran becausegoogle.cloud.firestore_v1was not installed. Running after another stub-heavy test can also produce an import-name failure from an empty stub module. The fallback keeps this unit test self-contained without changing production code.Validation
python -m pytest backend\tests\unit\test_conversations_count.py --collect-only -q --tb=shortpython -m pytest backend\tests\unit\test_conversations_count.py -q --tb=shortpython -m pytest backend\tests\unit\test_action_item_date_validation.py backend\tests\unit\test_conversations_count.py -q --tb=shortpython -m pytest backend\tests\unit\test_conversations_count.py backend\tests\unit\test_action_item_date_validation.py -q --tb=shortpython -m black --line-length 120 --skip-string-normalization backend\tests\unit\test_conversations_count.pypython -m py_compile backend\tests\unit\test_conversations_count.pygit diff --checkscripts\pre-commit