[codex] Isolate available plans Stripe imports#7945
Open
tianmind-studio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_available_plans_resilience.pyso the available-plans tests collect without the optional Stripe SDK installed.backend/utilspackage path before importingrouters.payment, while still stubbing heavy BYOK/external modules used only as import dependencies.get_available_plans_endpointbehavior with explicit per-test Stripe method mocks.Why
On a lightweight Windows backend test environment, collecting this test file failed at
import stripe. When another lightweight test ran first, it could also leave a stubbedutilspackage with no filesystem path, causingutils.subscriptionimport failures. This PR makes the test self-contained and order-tolerant without changing production code.Validation
python -m pytest backend\tests\unit\test_available_plans_resilience.py --collect-only -q --tb=shortpython -m pytest backend\tests\unit\test_available_plans_resilience.py -q --tb=shortpython -m pytest backend\tests\unit\test_action_item_date_validation.py backend\tests\unit\test_available_plans_resilience.py -q --tb=shortpython -m pytest backend\tests\unit\test_available_plans_resilience.py backend\tests\unit\test_action_item_date_validation.py -q --tb=shortpython -m black --line-length 120 --skip-string-normalization backend\tests\unit\test_available_plans_resilience.pypython -m py_compile backend\tests\unit\test_available_plans_resilience.pygit diff --checkscripts\pre-commit