[codex] Isolate phone call router test imports#7937
Open
tianmind-studio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_phone_calls.py.python-multipartin a lightweight Windows unit-test venv.utils/databasepackage paths so real modules such asutils.twilio_servicecan still import when needed.Root cause
test_phone_calls.pyalready stubs Twilio and Firebase, but importingrouters.phone_callsstill pulled in real database/quota/auth dependencies. On this Windows lightweight backend venv, standalone collection failed before any phone-call assertion ran:python -m pytest backend\tests\unit\test_phone_calls.py --collect-only -q --tb=short->ImportError: cannot import name 'firestore' from 'google.cloud'After the import stubs, the TwiML tests advanced to Starlette form parsing, where the same lightweight venv lacked
python-multipart. The test only sends URL-encoded fields, so this PR provides the minimum parser surface Starlette needs for those requests.Validation
python -m pytest backend\tests\unit\test_phone_calls.py --collect-only -q --tb=short->18 tests collectedpython -m pytest backend\tests\unit\test_phone_calls.py -q --tb=short->18 passed, 1 warningpython -m pytest backend\tests\unit\test_action_item_date_validation.py backend\tests\unit\test_phone_calls.py -q --tb=short->44 passed, 1 warningpython -m black --check --line-length 120 --skip-string-normalization backend\tests\unit\test_phone_calls.pypython -m py_compile backend\tests\unit\test_phone_calls.pygit diff --checkscripts/pre-commit