[codex] Keep Windows app checkouts on LF#7934
Open
tianmind-studio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.gitattributesfile underdesktop/windows..editorconfigand Prettier setup.Why
On this Windows checkout,
desktop/windowsfiles were written with CRLF becausecore.autocrlf=true. The Windows app already declaresend_of_line = lfin.editorconfig, so ESLint/Prettier reported almost every line asDelete ␍, hiding the real lint findings.This keeps the policy local to
desktop/windowsinstead of changing the whole repository or weakening Prettier withendOfLine: auto.Validation
prettier/prettiermessages; sampled messages wereDelete ␍.git check-attr -a -- desktop/windows/electron.vite.config.ts desktop/windows/eslint.config.mjs desktop/windows/.prettierrc.yaml->text: auto,eol: lffor all three files.core.autocrlf=true:desktop/windows/electron.vite.config.ts-> LF 26, CRLF 0desktop/windows/eslint.config.mjs-> LF 32, CRLF 0desktop/windows/src/renderer/src/lib/goals.test.ts-> LF 43, CRLF 0desktop/windows/.prettierrc.yaml-> LF 4, CRLF 0README.mdremained CRLF 174, showing the rule is scoped.prettier --check electron.vite.config.ts eslint.config.mjs .prettierrc.yaml src/renderer/src/lib/goals.test.tsin the fresh worktree -> passed.Delete ␍count 0; remaining messages are existing real lint/format findings.git diff --cached --check-> passed.C:\Program Files\Git\bin\bash.exe scripts/pre-commit-> passed.