[codex] Isolate Windows helper tests from Firebase#7933
Open
tianmind-studio wants to merge 4 commits into
Open
[codex] Isolate Windows helper tests from Firebase#7933tianmind-studio wants to merge 4 commits into
tianmind-studio wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
These tests exercise prompt builders, parsers, and tag helpers, but importing the modules also pulled in
apiClient/agentLLM, which initializes Firebase Auth throughfirebase.ts. On a fresh Windows test run without real Vite Firebase env values, Vitest failed at collection withFirebaseError: Firebase: Error (auth/invalid-api-key)before assertions could run.Validation
npx --yes pnpm@11.6.0 testfailed 4 suites withauth/invalid-api-key.npx --yes pnpm@11.6.0 exec vitest run src/renderer/src/lib/appMemories.test.ts src/renderer/src/lib/calendarExtract.test.ts src/renderer/src/lib/gmailExtract.test.ts src/renderer/src/lib/goals.test.ts-> 4 files passed, 18 tests passed.npx --yes pnpm@11.6.0 test-> 76 files passed, 1 skipped; 508 tests passed, 3 skipped.npx --yes pnpm@11.6.0 run typecheck-> passed.npx --yes pnpm@11.6.0 exec prettier --check src/renderer/src/lib/appMemories.test.ts src/renderer/src/lib/calendarExtract.test.ts src/renderer/src/lib/gmailExtract.test.ts src/renderer/src/lib/goals.test.ts-> passed.git diff --check-> passed.Note
npx --yes pnpm@11.6.0 run lintstill fails on this Windows checkout because of existing CRLF Prettier warnings and pre-existing lint errors outside these changed files; this PR keeps scope to the Firebase import-time test failure.