BAH-5026 | Drop the weekly cron from the Semgrep workflow - #348
BAH-5026 | Drop the weekly cron from the Semgrep workflow#348vishalkarmalkarthoughtworks wants to merge 1 commit into
Conversation
GitHub disables a scheduled workflow in a public repo after 60 days with no repository activity, and the disable applies to the whole workflow, not just the cron trigger. Bahmni/bahmni-api-test-automation and Bahmni/openmrs-module-bedmanagement had already lost Semgrep on every PR this way, and GitHub does not re-enable it when the repo becomes active again. Scanning on pull_request and on push to the default branch is unchanged, and workflow_dispatch stays for an on-demand full scan.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe weekly scheduled trigger was removed from the Semgrep workflow. Pull request, push, and manual dispatch triggers remain unchanged. Changes
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to The change removes the weekly cron while preserving pull request, default-branch push, and manual scan triggers; no actionable merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|



Removes the
schedule:trigger from.github/workflows/semgrep.yml. Two lines, no other change.Why
GitHub disables a scheduled workflow in a public repo after 60 days with no repository activity. Two details matter:
pull_requestandpushstop firing too, so Semgrep stops running on every PR.This already happened to two repos from this rollout.
semgrep.ymlwas in statedisabled_inactivityon Bahmni/bahmni-api-test-automation and Bahmni/openmrs-module-bedmanagement, so Semgrep had stopped running on their PRs entirely. Both have been re-enabled, and they would trip again in another 60 dormant days with the cron still in place.What is unaffected
workflow_dispatch, so an on-demand full scan is still one click in the Actions tab.Diff
Ticket: https://bahmni.atlassian.net/browse/BAH-5026
Summary by CodeRabbit