Skip to content

BAH-5026 | Drop the weekly cron from the Semgrep workflow - #348

Open
vishalkarmalkarthoughtworks wants to merge 1 commit into
masterfrom
BAH-5026
Open

BAH-5026 | Drop the weekly cron from the Semgrep workflow#348
vishalkarmalkarthoughtworks wants to merge 1 commit into
masterfrom
BAH-5026

Conversation

@vishalkarmalkarthoughtworks

@vishalkarmalkarthoughtworks vishalkarmalkarthoughtworks commented Aug 26, 2026

Copy link
Copy Markdown

Removes the schedule: trigger from .github/workflows/semgrep.yml. Two lines, no other change.

Why

GitHub disables a scheduled workflow in a public repo after 60 days with no repository activity. Two details matter:

  1. The disable applies to the whole workflow, not just the cron. pull_request and push stop firing too, so Semgrep stops running on every PR.
  2. GitHub never re-enables it. Activity resuming does not undo it.

This already happened to two repos from this rollout. semgrep.yml was in state disabled_inactivity on Bahmni/bahmni-api-test-automation and Bahmni/openmrs-module-bedmanagement, so Semgrep had stopped running on their PRs entirely. Both have been re-enabled, and they would trip again in another 60 dormant days with the cron still in place.

What is unaffected

  • Scanning on every pull request, and on push to the default branch. This is where the coverage comes from.
  • workflow_dispatch, so an on-demand full scan is still one click in the Actions tab.

Diff

 on:
   pull_request:
   push:
     branches: [main, master]
-  schedule:
-    - cron: '24 13 * * 1'
   workflow_dispatch:

Ticket: https://bahmni.atlassian.net/browse/BAH-5026

Summary by CodeRabbit

  • Chores
    • Removed the weekly scheduled security scan.
    • Pull request, push, and manual scan triggers remain available.

GitHub disables a scheduled workflow in a public repo after 60 days with no
repository activity, and the disable applies to the whole workflow, not just
the cron trigger. Bahmni/bahmni-api-test-automation and
Bahmni/openmrs-module-bedmanagement had already lost Semgrep on every PR this
way, and GitHub does not re-enable it when the repo becomes active again.

Scanning on pull_request and on push to the default branch is unchanged, and
workflow_dispatch stays for an on-demand full scan.
@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: fe0d229e-064f-43e8-8f09-51dd1dd4b4ca

📥 Commits

Reviewing files that changed from the base of the PR and between 6dbe45d and 1c852ad.

📒 Files selected for processing (1)
  • .github/workflows/semgrep.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/semgrep.yml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The weekly scheduled trigger was removed from the Semgrep workflow. Pull request, push, and manual dispatch triggers remain unchanged.

Changes

Cohort / File(s) Summary
Semgrep workflow
.github/workflows/semgrep.yml
Removes the weekly scheduled workflow trigger. Other triggers remain unchanged.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 1c852

The change removes the weekly cron while preserving pull request, default-branch push, and manual scan triggers; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the weekly cron trigger from the Semgrep workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch BAH-5026

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant