Skip to content

Add no known allergy concept UUID as global property - #324

Open
vvkpd wants to merge 2 commits into
Bahmni:masterfrom
cureinternational:no-known-allergy
Open

Add no known allergy concept UUID as global property#324
vvkpd wants to merge 2 commits into
Bahmni:masterfrom
cureinternational:no-known-allergy

Conversation

@vvkpd

@vvkpd vvkpd commented May 18, 2026

Copy link
Copy Markdown

Summary

  • Adds a new global property allergy.concept.noKnownAllergyUuid via a Liquibase changeset in bahmnicore-omod
  • The property stores the UUID of the "No Known Allergy" concept, enabling frontends to identify and handle this special allergy entry (e.g. strike-through display, localisation support) without hardcoding the UUID or relying on text matching

Changes

  • bahmnicore-omod/src/main/resources/liquibase.xml: adds changeset bahmni-core-202601151218 with a pre-condition guard (MARK_RAN if property already exists)

Test plan

  • Run Bahmni with this module — verify allergy.concept.noKnownAllergyUuid appears in OpenMRS global properties after startup
  • Run the changeset a second time — confirm it is skipped (MARK_RAN) without error
  • Verify existing allergy workflows are unaffected

Summary by CodeRabbit

  • Chores
    • Configured system to properly initialize allergy tracking settings on first deployment.

Review Change Stack

@coderabbitai

coderabbitai Bot commented May 18, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1261b0d3-4977-4494-a996-3ee43ec47257

📥 Commits

Reviewing files that changed from the base of the PR and between d12197d and 0447baa.

📒 Files selected for processing (1)
  • bahmnicore-omod/src/main/resources/liquibase.xml

📝 Walkthrough

Walkthrough

This pull request introduces a single Liquibase database migration that adds a global property configuration for an allergy concept UUID. The changeSet is conditionally executed only when the property does not already exist, ensuring idempotent deployment across environments.

Changes

Allergy Concept Configuration

Layer / File(s) Summary
Allergy concept UUID global property migration
bahmnicore-omod/src/main/resources/liquibase.xml
New Liquibase changeSet (bahmni-core-202601151218) conditionally inserts the allergy.concept.noKnownAllergyUuid global property with a fixed concept UUID value. The insertion includes a precondition check to prevent duplicate entries.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 A little UUID hops in,
For allergies we now begin,
No known property shall be strange,
One migration paves the way for change! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately and concisely summarizes the main change: adding a new global property for the no known allergy concept UUID.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants